Add HTML entity replacements for tab and space characters#7
Closed
LaurentAerens wants to merge 3 commits intodmsnell:mainfrom
Closed
Add HTML entity replacements for tab and space characters#7LaurentAerens wants to merge 3 commits intodmsnell:mainfrom
LaurentAerens wants to merge 3 commits intodmsnell:mainfrom
Conversation
Author
|
Is there any potential this PR could get a review? |
…tps://github.com/LaurentAerens/diff-match-patch into fix/c-sharp-leading-and-trailing-spaces-and-tabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff_prettyHtmlcurrently doesn't highlight leading/trailing space differences. Because spaces in HTML aren't visible.This pull request changes that.
Instead of
diff_prettyHtmlnow returnsresulting in differences with leading/training spaces being visible in HTML.
Example:
When we compare "Test" and "Test " (notice the second string doesn't equal the first string since it has a trailing space).
Previously looked like this:
Now with this pull requests it looks like this:
Note: this issue also seems to be present in the JavaScript implementation: google#144